linux-kernel - Re: [PATCH v2] bus: mhi: core: Fix reading wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211203084301.GA18809@thinkpad>
Date:   Fri, 3 Dec 2021 14:13:01 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Bhaumik Bhatt <quic_bbhatt@...cinc.com>
Cc:     linux-arm-msm@...r.kernel.org, quic_hemantk@...cinc.com,
        quic_jhugo@...cinc.com, linux-kernel@...r.kernel.org,
        mhi@...ts.linux.dev, stable@...r.kernel.org,
        quic_olgak@...cinc.com, loic.poulain@...aro.org
Subject: Re: [PATCH v2] bus: mhi: core: Fix reading wake_capable channel
 configuration

On Tue, Nov 30, 2021 at 05:01:31PM -0800, Bhaumik Bhatt wrote:
> The 'wake-capable' entry in channel configuration is not set when
> parsing the configuration specified by the controller driver. Add
> the missing entry to ensure channel is correctly specified as a
> 'wake-capable' channel.
> 
> Cc: stable@...r.kernel.org
> Fixes: 0cbf260820fa ("bus: mhi: core: Add support for registering MHI controllers")
> Signed-off-by: Bhaumik Bhatt <quic_bbhatt@...cinc.com>
> Reviewed-by: Manivannan Sadhasivam <mani@...nel.org>

Applied to mhi-next!

Thanks,
Mani

> ---
>  drivers/bus/mhi/core/init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> v2:
> -Update subject as per comments
> -Add fixes tag and CC stable
> 
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index 5aaca6d..f1ec3441 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -788,6 +788,7 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,
>  		mhi_chan->offload_ch = ch_cfg->offload_channel;
>  		mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch;
>  		mhi_chan->pre_alloc = ch_cfg->auto_queue;
> +		mhi_chan->wake_capable = ch_cfg->wake_capable;
>  
>  		/*
>  		 * If MHI host allocates buffers, then the channel direction
> -- 
> 2.7.4
>