linux-kernel - Re: [PATCH] hwrng: cn10k: Add random number generator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202112031752.wdInk91s-lkp@intel.com>
Date:   Fri, 3 Dec 2021 17:12:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     sgoutham@...vell.com, herbert@...dor.apana.org.au,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, sunil.kovvuri@...il.com,
        Sunil Goutham <sgoutham@...vell.com>,
        Bharat Bhushan <bbhushan2@...vell.com>,
        Joseph Longever <jlongever@...vell.com>
Subject: Re: [PATCH] hwrng: cn10k: Add random number generator support

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on herbert-cryptodev-2.6/master linux/master linus/master v5.16-rc3 next-20211202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/sgoutham-marvell-com/hwrng-cn10k-Add-random-number-generator-support/20211130-015707
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 5d331b5922551637c586cdf5fdc1778910fc937f
config: arm64-randconfig-s031-20211203 (https://download.01.org/0day-ci/archive/20211203/202112031752.wdInk91s-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/395a6a89774841f3f1c9d994b7d8cdfaf25bc428
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review sgoutham-marvell-com/hwrng-cn10k-Add-random-number-generator-support/20211130-015707
        git checkout 395a6a89774841f3f1c9d994b7d8cdfaf25bc428
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/char/hw_random/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/char/hw_random/cn10k-rng.c:88:17: sparse: sparse: cast removes address space '__iomem' of expression

vim +/__iomem +88 drivers/char/hw_random/cn10k-rng.c

    82	
    83	static int cn10k_read_trng(struct cn10k_rng *rng, u64 *value)
    84	{
    85		u64 addr, result = 0;
    86		int retry_count = 5;
    87	
  > 88		addr = (u64)rng->reg_base + RNM_PF_RANDOM;
    89		/* TRNG and status need to be read at a time */
    90		while (!result && retry_count) {
    91			__asm__ volatile("ldp  %0,%1,[%2]" :\
    92					 "=r" (*value), "=r" (result) : "r" (addr) : );
    93	
    94			retry_count--;
    95		}
    96	
    97		return retry_count ? 0 : -EIO;
    98	}
    99	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org