linux-kernel - Re: [PATCH V6 00/49] x86/entry/64: Convert a bunch of ASM entry code into C code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yanu9wLar6Dp6UQ6@zn.tnic>
Date:   Fri, 3 Dec 2021 11:18:31 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Lai Jiangshan <laijs@...ux.alibaba.com>
Cc:     Lai Jiangshan <jiangshanlai@...il.com>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH V6 00/49] x86/entry/64: Convert a bunch of ASM entry code
 into C code

On Fri, Dec 03, 2021 at 06:10:47PM +0800, Lai Jiangshan wrote:
> It is not urgent nor it is something should be put in cold cellar.
> Please consider queuing the first three patches at least.

So there are fixes in there, which should go now. It's what I thought
too when looking at those and was about to suggest to send them
separately but that's fine - I can pick them out.

> It is cold for a week, I think a ping is proper than a resending.

With such a huge patchset I don't think you need to ping or resend every
week but only after people have looked at it at least somewhat. But I'm
sure you can imagine people are busy as hell so looking at that takes
time so you'd need to be patient.

It might be even helpful if you could split it into more palatable
portions of maybe 10-ish patches each, if possible, and then send the
first portion, wait for review and only send the second portion after
the first has been applied, etc.

That would make life easier for everyone involved.

> The asm entry code is always a pain and this patchset gives a start
> in future with reduced asm code and pain because some future changes
> might be redirected from asm to the C hopefully.

Yes, I think we all agree on that.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette