linux-kernel - Re: [PATCH 1/1] riscv: dts: fu740: Add PDMA node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <DC14F9FB-D4E8-48DC-958A-CFEF2115F803@jrtc27.com>
Date:   Fri, 3 Dec 2021 10:50:46 +0000
From:   Jessica Clarke <jrtc27@...c27.com>
To:     "v.v.mitrofanov" <v.v.mitrofanov@...ro.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        David Abdurachmanov <david.abdurachmanov@...ive.com>,
        Yash Shah <yash.shah@...ive.com>,
        Atish Patra <atish.patra@....com>,
        Greentime Hu <greentime.hu@...ive.com>,
        devicetree <devicetree@...r.kernel.org>,
        linux-riscv <linux-riscv@...ts.infradead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] riscv: dts: fu740: Add PDMA node

On 3 Dec 2021, at 09:57, v.v.mitrofanov <v.v.mitrofanov@...ro.com> wrote:
> 
> HiFive unmatched supports PDMA but is not implemented in DT.
> 
> Add the PDMA node in SiFive FU740 soc-specific DT file.
> 
> Signed-off-by: v.v.mitrofanov <v.v.mitrofanov@...ro.com>
> ---
> arch/riscv/boot/dts/sifive/fu740-c000.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/sifive/fu740-c000.dtsi b/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> index 64ff2e758336..833fb4f4376b 100644
> --- a/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> +++ b/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> @@ -164,6 +164,13 @@ prci: clock-controller@...00000 {
> 			#clock-cells = <1>;
> 			#reset-cells = <1>;
> 		};
> +		dma: dma@...0000 {
> +			compatible = "sifive,fu540-c000-pdma";

I know the PLIC and CGEM devices abuse fu540-specific compatible
strings (which it would be great to fix; FreeBSD is already prepared
for that, though it’d also be nice to introduce a generic compatible
string for the SiFive CGEM rather than having just a SoC-specific one
given the FU540 and FU740 have the same interface), but let’s not make
things worse. This should say fu740, and there should also be a generic
SiFive PDMA compatible so we don’t need to add a new compatible to an
otherwise-unchanged driver every time a new SiFive SoC appears.

Jess