linux-kernel - Re: [PATCH] media: uvcvideo: fix division by zero at stream start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yan241Kg7O+qgQXG@pendragon.ideasonboard.com>
Date:   Fri, 3 Dec 2021 12:52:19 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Kieran Bingham <kieran.bingham@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] media: uvcvideo: fix division by zero at stream start

Hi Johan,

On Fri, Dec 03, 2021 at 11:29:07AM +0100, Johan Hovold wrote:
> On Wed, Oct 27, 2021 at 12:50:46AM +0300, Laurent Pinchart wrote:
> > On Tue, Oct 26, 2021 at 02:06:55PM +0200, Johan Hovold wrote:
> > > On Tue, Oct 26, 2021 at 02:15:20PM +0300, Laurent Pinchart wrote:
> > > > On Tue, Oct 26, 2021 at 11:55:05AM +0100, Kieran Bingham wrote:
> > > > > Quoting Johan Hovold (2021-10-26 10:55:11)
> > > > > > Add the missing bulk-endpoint max-packet sanity check to probe() to
> > > > > > avoid division by zero in uvc_alloc_urb_buffers() in case a malicious
> > > > > > device has broken descriptors (or when doing descriptor fuzz testing).
> > > > > > 
> > > > > > Note that USB core will reject URBs submitted for endpoints with zero
> > > > > > wMaxPacketSize but that drivers doing packet-size calculations still
> > > > > > need to handle this (cf. commit 2548288b4fb0 ("USB: Fix: Don't skip
> > > > > > endpoint descriptors with maxpacket=0")).
> > > > > > 
> > > > > > Fixes: c0efd232929c ("V4L/DVB (8145a): USB Video Class driver")
> > > > > > Cc: stable@...r.kernel.org      # 2.6.26
> > > > > > Signed-off-by: Johan Hovold <johan@...nel.org>
> > >
> > > Note however the copy-paste error in the commit message mentioning
> > > probe(), which is indeed where this would typically be handled.
> > > 
> > > Do you want me to resend or can you change
> > > 
> > > 	s/probe()/uvc_video_start_transfer()/
> > > 
> > > in the commit message when applying if you think this is acceptable as
> > > is?
> > 
> > I can fix this when applying.
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> I noticed that this one hasn't showed up in linux-next yet. Do you still
> have it in your queue or do you want me to resend?

It should be in Mauro's queue now:

https://lore.kernel.org/all/YacOun3Diggsi05V@pendragon.ideasonboard.com/

-- 
Regards,

Laurent Pinchart