linux-kernel - Re: [PATCH v1 1/1] leds: tca6507: Get rid of duplicate of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaoLImUJb0K/IVOL@smile.fi.intel.com>
Date:   Fri, 3 Dec 2021 14:18:42 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Pavel Machek <pavel@....cz>
Cc:     Yihao Han <hanyihao@...o.com>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] leds: tca6507: Get rid of duplicate of_node
 assignment

On Fri, Dec 03, 2021 at 08:31:21AM +0100, Pavel Machek wrote:
> Hi!
> 
> > GPIO library does copy the of_node from the parent device of
> > the GPIO chip, there is no need to repeat this in the individual
> > drivers. Remove assignment here.
> > 
> > For the details one may look into the of_gpio_dev_init()
> > implementation.
> 
> So... where do you see of_gpio_dev_init called in this particular
> case?

Inside GPIO library as stated in the commit message.

  --> tca6507_probe_gpios()
    --> gpiochip_add_data()
      --> gpiochip_add_data_with_key()
        --> of_gpio_dev_init()


-- 
With Best Regards,
Andy Shevchenko