linux-kernel - [peterz-queue:x86/wip.ibt 11/15] arch/x86/kernel/traps.c:647:7: error: implicit declaration of function 'x86_feature_enabled'; did you mean 'cpu_feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 3 Dec 2021 20:36:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [peterz-queue:x86/wip.ibt 11/15] arch/x86/kernel/traps.c:647:7:
 error: implicit declaration of function 'x86_feature_enabled'; did you mean
 'cpu_feature_enabled'?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git x86/wip.ibt
head:   80bc7f2a129848b0885cf214fda77f623ba2f5f9
commit: 715bf971dc2ec830ebcc60df3edcc7935d04332a [11/15] x86: Add IBT feature, MSR and #CP handling
config: x86_64-randconfig-r003-20211203 (https://download.01.org/0day-ci/archive/20211203/202112032046.J9J12rUt-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=715bf971dc2ec830ebcc60df3edcc7935d04332a
        git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
        git fetch --no-tags peterz-queue x86/wip.ibt
        git checkout 715bf971dc2ec830ebcc60df3edcc7935d04332a
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

Note: the peterz-queue/x86/wip.ibt HEAD 80bc7f2a129848b0885cf214fda77f623ba2f5f9 builds fine.
      It only hurts bisectability.

All errors (new ones prefixed by >>):

   arch/x86/kernel/traps.c: In function '__exc_control_protection':
>> arch/x86/kernel/traps.c:647:7: error: implicit declaration of function 'x86_feature_enabled'; did you mean 'cpu_feature_enabled'? [-Werror=implicit-function-declaration]
     647 |  if (!x86_feature_enabled(X86_FEATURE_IBT)) {
         |       ^~~~~~~~~~~~~~~~~~~
         |       cpu_feature_enabled
   In file included from include/linux/kernel.h:20,
                    from arch/x86/include/asm/percpu.h:27,
                    from arch/x86/include/asm/current.h:6,
                    from include/linux/sched.h:12,
                    from include/linux/context_tracking.h:5,
                    from arch/x86/kernel/traps.c:15:
   include/linux/kern_levels.h:5:18: warning: format '%p' expects argument of type 'void *', but argument 2 has type 'long unsigned int' [-Wformat=]
       5 | #define KERN_SOH "\001"  /* ASCII Start Of Header */
         |                  ^~~~~~
   include/linux/printk.h:422:11: note: in definition of macro 'printk_index_wrap'
     422 |   _p_func(_fmt, ##__VA_ARGS__);    \
         |           ^~~~
   include/linux/printk.h:493:2: note: in expansion of macro 'printk'
     493 |  printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
         |  ^~~~~~
   include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
      11 | #define KERN_ERR KERN_SOH "3" /* error conditions */
         |                  ^~~~~~~~
   include/linux/printk.h:493:9: note: in expansion of macro 'KERN_ERR'
     493 |  printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~~~
   arch/x86/kernel/traps.c:655:2: note: in expansion of macro 'pr_err'
     655 |  pr_err("Missing ENDBR: %pS\n", instruction_pointer(regs));
         |  ^~~~~~
   cc1: some warnings being treated as errors


vim +647 arch/x86/kernel/traps.c

   643	
   644	#ifdef CONFIG_X86_IBT
   645	DEFINE_IDTENTRY_ERRORCODE(exc_control_protection)
   646	{
 > 647		if (!x86_feature_enabled(X86_FEATURE_IBT)) {
   648			pr_err("Whaaa?!?!\n");
   649			return;
   650		}
   651	
   652		if (WARN_ON_ONCE(user_mode(regs) || error_code != 3))
   653			return;
   654	
   655		pr_err("Missing ENDBR: %pS\n", instruction_pointer(regs));
   656		return;
   657	}
   658	#endif
   659	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org