linux-kernel - Re: [PATCH v1 1/2] ASoC: ti: davinci-mcasp: Get rid of duplicate of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Dec 2021 16:45:31 +0200
From:   Péter Ujfalusi <peter.ujfalusi@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH v1 1/2] ASoC: ti: davinci-mcasp: Get rid of duplicate
 of_node assignment



On 02/12/2021 22:56, Andy Shevchenko wrote:
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove assignment here.

Thanks, looks good,
Acked-by: Peter Ujfalusi <peter.ujfalusi@...il.com>

> For the details one may look into the of_gpio_dev_init() implementation.

Which works after commit 1df62542e0161.

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  sound/soc/ti/davinci-mcasp.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c
> index 56a19eeec5c7..81c1ccec5904 100644
> --- a/sound/soc/ti/davinci-mcasp.c
> +++ b/sound/soc/ti/davinci-mcasp.c
> @@ -2230,9 +2230,6 @@ static int davinci_mcasp_init_gpiochip(struct davinci_mcasp *mcasp)
>  	mcasp->gpio_chip = davinci_mcasp_template_chip;
>  	mcasp->gpio_chip.label = dev_name(mcasp->dev);
>  	mcasp->gpio_chip.parent = mcasp->dev;
> -#ifdef CONFIG_OF_GPIO
> -	mcasp->gpio_chip.of_node = mcasp->dev->of_node;
> -#endif
>  
>  	return devm_gpiochip_add_data(mcasp->dev, &mcasp->gpio_chip, mcasp);
>  }
> 

-- 
Péter