linux-kernel - RE: [PATCH net-next v3 2/2] net: ethernet: Add driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Dec 2021 01:36:41 +0000
From:   Wells Lu 呂芳騰 <wells.lu@...plus.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Wells Lu <wellslutw@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        Vincent Shih 施錕鴻 
        <vincent.shih@...plus.com>
Subject: RE: [PATCH net-next v3 2/2] net: ethernet: Add driver for Sunplus
 SP7021

Hi Andrew,

Thank you for explanation.


Best regards,
Wells Lu


> > Hi Andrew,
> >
> > Thank you for explanation.
> >
> > I'll add phy_support_asym_pause() after PHY connected next patch.
> >
> > I found some drivers call phy_set_max_speed() to set PHY speed to 100M
> > after PHY connected. Is that necessary?
> 
> > From 'supported', PHY supports 10M/100M already.
> 
> You need phy_set_max_speed() when it is possible to connect a 10/100 MAC to a 1G PHY.  You
> sometime do this because a 1G PHY is cheaper than a 100M PHY. Unless limited, the PHY will
> advertise and could negotiate a 1G link, but the MAC could then not support it. If it is
> not physically possible to connect a 1G PHY to your MAC, you don't need to worry.
> 
> > I also found some drivers call phy_start_aneg() after PHY started.
> 
> It is not needed.
> 
>    Andrew