linux-kernel - Re: [PATCH v3] MAINTAINERS: Update Atish's email address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Dec 2021 16:10:30 +0000
From:   Steven Price <steven.price@....com>
To:     Atish Patra <atishp@...shpatra.org>, linux-kernel@...r.kernel.org
Cc:     anup.patel@....com, kvm@...r.kernel.org,
        kvm-riscv@...ts.infradead.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v3] MAINTAINERS: Update Atish's email address

On 02/12/2021 23:58, Atish Patra wrote:
> I am no longer employed by western digital. Update my email address to
> personal one and add entries to .mailmap as well.
> 
> Signed-off-by: Atish Patra <atishp@...shpatra.org>
> ---
>  .mailmap    | 1 +
>  MAINTAINERS | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/.mailmap b/.mailmap
> index 6277bb27b4bf..23f6b0a60adf 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -50,6 +50,7 @@ Archit Taneja <archit@...com>
>  Ard Biesheuvel <ardb@...nel.org> <ard.biesheuvel@...aro.org>
>  Arnaud Patard <arnaud.patard@...-net.org>
>  Arnd Bergmann <arnd@...db.de>
> +Atish Patra <atishp@...shpatra.org> <atish.patra@....com> <atishp@...osinc.com>

I don't think this does what you expect. You can't list more than one
email address to replace on the same line. You can use the command "git
check-mailmap" to test what happens, e.g. with this change applied:

  $ git check-mailmap "<atishp@...osinc.com>"
  <atishp@...osinc.com>
  $ git check-mailmap "<atish.patra@....com>"
  Atish Patra <atishp@...shpatra.org>
  $ git check-mailmap "<atishp@...shpatra.org>"
  <atishp@...shpatra.org>

So only your @wdc.com address is translated. If you want to translate
the @rivosinc.com address as well you need a second line. As the file says:

# For format details, see "MAPPING AUTHORS" in "man git-shortlog".

Steve

>  Axel Dyks <xl@...igned.net>
>  Axel Lin <axel.lin@...il.com>
>  Bart Van Assche <bvanassche@....org> <bart.vanassche@...disk.com>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5250298d2817..6c2a34da0314 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10434,7 +10434,7 @@ F:	arch/powerpc/kvm/
>  
>  KERNEL VIRTUAL MACHINE FOR RISC-V (KVM/riscv)
>  M:	Anup Patel <anup.patel@....com>
> -R:	Atish Patra <atish.patra@....com>
> +R:	Atish Patra <atishp@...shpatra.org>
>  L:	kvm@...r.kernel.org
>  L:	kvm-riscv@...ts.infradead.org
>  L:	linux-riscv@...ts.infradead.org
>