linux-kernel - Re: [RFC PATCH] watchdog: da9062: Correct the timeout values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dc6a432c-79a3-881c-eac4-32620040d11b@roeck-us.net>
Date:   Fri, 3 Dec 2021 08:52:12 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Christoph Niedermaier <cniedermaier@...electronics.com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     Support Opensource <support.opensource@...semi.com>,
        Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Andrej Picej <andrej.picej@...ik.com>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] watchdog: da9062: Correct the timeout values

On 12/3/21 8:35 AM, Christoph Niedermaier wrote:
> I measured the timeout values of my DA9061 chip. According to the
> information in the data sheet the formula should be:
> 
> timeout = 2.048 * 2^(regval - 1)
> 
> But my measured values differ from that.
> Accoring to my measured values the formula must be:
> 
> timeout = 3.2 * 2^(regval - 1)
> 
> Is there something wrong with my chip, or has anyone else noticed this as well?

The driver assumes a static and well defined clock rate. Maybe that rate
is different in your system (if that is possible) ?

Guenter

> 
> Signed-off-by: Christoph Niedermaier <cniedermaier@...electronics.com>
> Cc: Support Opensource <support.opensource@...semi.com>
> Cc: Adam Thomson <Adam.Thomson.Opensource@...semi.com>
> Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Andrej Picej <andrej.picej@...ik.com>
> Cc: linux-watchdog@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> To: linux-arm-kernel@...ts.infradead.org
> ---
>   drivers/watchdog/da9062_wdt.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/da9062_wdt.c b/drivers/watchdog/da9062_wdt.c
> index f02cbd530538..d2576aba9ca5 100644
> --- a/drivers/watchdog/da9062_wdt.c
> +++ b/drivers/watchdog/da9062_wdt.c
> @@ -20,7 +20,8 @@
>   #include <linux/regmap.h>
>   #include <linux/of.h>
>   
> -static const unsigned int wdt_timeout[] = { 0, 2, 4, 8, 16, 32, 65, 131 };
> +static const unsigned int wdt_timeout[] = { 0, 3, 6, 12, 25, 51, 102, 204 };
> +
>   #define DA9062_TWDSCALE_DISABLE		0
>   #define DA9062_TWDSCALE_MIN		1
>   #define DA9062_TWDSCALE_MAX		(ARRAY_SIZE(wdt_timeout) - 1)
>