linux-kernel - Re: [PATCH v2] of/irq: Add a quirk for controllers with their own definition of interrupt-map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YapROd/1lE/Yb0DQ@robh.at.kernel.org>
Date:   Fri, 3 Dec 2021 11:17:45 -0600
From:   Rob Herring <robh@...nel.org>
To:     Marc Zyngier <maz@...nel.org>
Cc:     Biwen Li <biwen.li@....com>, devicetree@...r.kernel.org,
        Chris Brandt <chris.brandt@...esas.com>,
        linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Sander Vanheule <sander@...nheule.net>,
        John Crispin <john@...ozen.org>, kernel-team@...roid.com
Subject: Re: [PATCH v2] of/irq: Add a quirk for controllers with their own
 definition of interrupt-map

On Wed, 01 Dec 2021 11:41:02 +0000, Marc Zyngier wrote:
> Since 041284181226 ("of/irq: Allow matching of an interrupt-map local
> to an interrupt controller"), a handful of interrupt controllers have
> stopped working correctly. This is due to the DT exposing a non-sensical
> interrupt-map property, and their drivers relying on the kernel ignoring
> this property.
> 
> Since we cannot realistically fix this terrible behaviour, add a quirk
> for the limited set of devices that have implemented this monster,
> and document that this is a pretty bad practice.
> 
> Cc: Rob Herring <robh@...nel.org>
> Cc: John Crispin <john@...ozen.org>
> Cc: Biwen Li <biwen.li@....com>
> Cc: Chris Brandt <chris.brandt@...esas.com>
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: Sander Vanheule <sander@...nheule.net>
> Signed-off-by: Marc Zyngier <maz@...nel.org>
> ---
> 
> Notes:
>     v2: Switched over to of_device_compatible_match() as per Rob's
>         request.
> 
>  drivers/of/irq.c | 28 ++++++++++++++++++++++++++--
>  1 file changed, 26 insertions(+), 2 deletions(-)
> 

Applied, thanks!