linux-kernel - RE: [PATCH v2 0/3] topology/sysfs: only export used sysfs attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c63a4971458c49c7a0cb0a8ba48ceb2d@hisilicon.com>
Date:   Sat, 4 Dec 2021 11:45:58 +0000
From:   "Song Bao Hua (Barry Song)" <song.bao.hua@...ilicon.com>
To:     Brice Goglin <Brice.Goglin@...ia.fr>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Heiko Carstens <hca@...ux.ibm.com>
CC:     Peter Zijlstra <peterz@...radead.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Jonathan Cameron" <jonathan.cameron@...wei.com>,
        Len Brown <len.brown@...el.com>,
        Thomas Richter <tmricht@...ux.ibm.com>,
        Ian Rogers <irogers@...gle.com>
Subject: RE: [PATCH v2 0/3] topology/sysfs: only export used sysfs attributes



> -----Original Message-----
> From: Brice Goglin [mailto:Brice.Goglin@...ia.fr]
> Sent: Saturday, December 4, 2021 10:48 PM
> To: Song Bao Hua (Barry Song) <song.bao.hua@...ilicon.com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Heiko Carstens <hca@...ux.ibm.com>
> Cc: Peter Zijlstra <peterz@...radead.org>; Rafael J . Wysocki
> <rafael@...nel.org>; Andrew Morton <akpm@...ux-foundation.org>;
> linux-kernel@...r.kernel.org; Jonathan Cameron <jonathan.cameron@...wei.com>;
> Len Brown <len.brown@...el.com>; Thomas Richter <tmricht@...ux.ibm.com>; Ian
> Rogers <irogers@...gle.com>
> Subject: Re: [PATCH v2 0/3] topology/sysfs: only export used sysfs attributes
> 
> Le 04/12/2021 à 10:07, Song Bao Hua (Barry Song) a écrit :
> >
> > Could you give me one minute?
> >
> > +Brice
> >
> > I'd like to hear some feedbacks from hwloc if there
> > is a chance to break userspace and if userspace depends
> > on the existence of sysfs even though the topology
> > doesn't exist.
> >
> > If no, I feel it is safe to take.
> >
> 
> Hello
> 
> If the question is whether hwloc *requires* cluster/die/book/drawer
> sysfs files to exist, then the answer is no. We have to support old
> kernels without those files anyway.

Thanks for clarification, Brice. I saw hwloc is reading sysfs
drawer, book and cluster. But since it doesn't assume their
existence in sysfs, I have more confidence on this patchset
now.

Greg, please ignore my comment then :-)

> 
> Brice
> 
> 

Thanks
Barry