linux-kernel - Re: [PATCH 2/2] fs/dcache: avoid unused-function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211204115714.kle6llg6ndmslt3q@wittgenstein>
Date:   Sat, 4 Dec 2021 12:57:14 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Jonathan Corbet <corbet@....net>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Hao Li <lihao2018.fnst@...fujitsu.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] fs/dcache: avoid unused-function warning

On Fri, Dec 03, 2021 at 08:01:02PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Now that 'dentry_stat' is marked 'static', we can run into this warning:
> 
> fs/dcache.c:128:29: error: 'dentry_stat' defined but not used [-Werror=unused-variable]
>   128 | static struct dentry_stat_t dentry_stat = {
> 
> Hide it in the same #ifdef as its only references.
> 
> Fixes: f0eea17ca8da ("fs: move dcache sysctls to its own file")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Looks good.
Acked-by: Christian Brauner <christian.brauner@...ntu.com>