linux-kernel - Re: [RFC v2 19/19] ima: Setup securityfs for IMA namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b285b0d4-e615-bea4-f22f-09d83f8f8edb@linux.ibm.com>
Date:   Fri, 3 Dec 2021 19:33:39 -0500
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     jejb@...ux.ibm.com, linux-integrity@...r.kernel.org
Cc:     zohar@...ux.ibm.com, serge@...lyn.com,
        christian.brauner@...ntu.com, containers@...ts.linux.dev,
        dmitry.kasatkin@...il.com, ebiederm@...ssion.com,
        krzysztof.struczynski@...wei.com, roberto.sassu@...wei.com,
        mpeters@...hat.com, lhinds@...hat.com, lsturman@...hat.com,
        puiterwi@...hat.com, jamjoom@...ibm.com,
        linux-kernel@...r.kernel.org, paul@...l-moore.com, rgb@...hat.com,
        linux-security-module@...r.kernel.org, jmorris@...ei.org
Subject: Re: [RFC v2 19/19] ima: Setup securityfs for IMA namespace


On 12/3/21 14:11, Stefan Berger wrote:
>
> On 12/3/21 13:50, James Bottomley wrote:
>
>
>>
>>> Where would the vfsmount pointer reside? For now it's in
>>> ima_namespace, but it sounds like it should be in a more centralized
>>> place? Should it also be  connected to the user_namespace so we can
>>> pick it up using get_user_ns()?
>> exactly.  I think struct user_namespace should have two elements gated
>> by a #ifdef CONFIG_SECURITYFS which are the vfsmount and the
>> mount_count for passing into simple_pin_fs.
>
> Also that we can do for as long as it flies beyond the conversation 
> here... :-) Anyone else have an opinion ?

I moved it now and this greatly reduced the amount of changes. The 
dentries are now all in the ima_namespace and it works with one API. Thanks!

I wonder whether to move the integrity dir also into the ima_namespace. 
It's generated in integrity/iint.c, so not in the IMA territory... For 
the IMA namespacing case I need to create it as well, though.

https://elixir.bootlin.com/linux/latest/source/security/integrity/iint.c#L218

    Stefan