Message-ID: <20211204154210.535c28c7@jic23-huawei>
Date:   Sat, 4 Dec 2021 15:42:32 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Cosmin Tanislav <demonsingur@...il.com>
Cc:     cosmin.tanislav@...log.com, Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Rob Herring <robh+dt@...nel.org>, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v8 0/3] Add AD74413R driver

On Fri,  3 Dec 2021 00:41:00 +0200
Cosmin Tanislav <demonsingur@...il.com> wrote:


Hi Cosmin,

A quick process note.  If you do find an issue with a series you've
sent out which hasn't had any negative feedback etc, then please send a reply
to that earlier version to say that.

I've been known to pick up the wrong version when people do multiple series
without replies like you have here.  Also tends to lead to people reviewing
the wrong version.

I'll get to v9 shortly :)

Jonathan



> V1 -> V2
>  * sign off using company email
> 
> V2 -> V3
>  * replace gpo config firmware flag with flag specifying whether gpo is in
>    comparator mode
>  * create two separate gpiochips, one output-only gpiochip for GPO pins not
>    in comparator mode and one input-only for the value of digital input
>    channels
>  * wire up all gpo functionalities using pinconf
>  * keep number of characters per line under 80
>  * rework locking
>  * do not invalidate other chip revisions
>  * do not set indio device parent
>  * print probe error for refin regulator
>  * move conversion from range register value to range / offset / raw offset
>    into separate function
>  * module.h -> mod_devicetable.h
>  * use generic firmware interface functions
>  * add comment regarding cache alignment
>  * add comment regarding ADC channels buffered read setup
>  * un-inline comment regarding 100us delay for conversion start
>  * inline return statements
>  * remove assignments to val2 where not necessary
>  * local_channels -> chans
>  * index -> i
>  * channel_config -> config
>  * IIO_ALTVOLTAGE -> IIO_VOLTAGE
>  * .info_mask_shared_by_type_available -> .info_mask_separate_available
>  * remove unlikely probe error messages
>  * use an array indexed by channel function for retrieving iio channels
>  * count iio channels while parsing
>  * move HART rate rejection outside of setter
>  * move channel function validation outside of setter
>  * use SPI messages for read and write
>  * validate DAC code earlier
>  * simplify switches to only handle existing iio channels
>  * pass indio_dev into functions needing access to it
>  * pass spi into devm_regmap_init
>  * dt-bindings: sort compatibles
>  * dt-bindings: remove driver word from description
>  * dt-bindings: remove refin supply description
>  * dt-bindings: specify channel function default value
>  * dt-bindings: remove maxItems from scalar value
> 
> V3 -> v4
>  * remove double gpo from macro name
>  * reset at probe
>  * config -> chip_info and store chip name inside chip info
>  * cacheline align every DMA buffer
>  * simplify generation of adc samples message by caching xfer, tx_buf and
>    rx_buf
>  * use mask itself for writing the value of channel enable and gpo data
>  * move reg read and write transfers to the same buffers and use local
>    variables for transfers
>  * merge the two for loops handling gpio configuration
>  * let firmware decide irq edge
>  * remove INDIO_BUFFER_SOFTWARE already set by iio framwork
>  * do not set trigger device parent
>  * return dev_err_probe for regulator error case
>  * do not set cs_change to 0 when not needed
>  * do not set spi device drvdata as it is not needed
>  * fix bug regarding wrong channels being created for resistance input,
>    digital input, and current input with hart
>  * use voltage input channels spec for high impedance mode
>  * put () around macro parameters
>  * merge AD74413R_CHANNEL macro into its uses
>  * remove unused switch case scope
>  * inline return IIO_VAL_INT
>  * use {get,put}_unaligned_be16
>  * use proper types for reg and val
>  * move default case handling into switch statements
>  * pass driver state into regmap functions
>  * use genmask for generating a 16bit max value
>  * alphanumeric order for part numbers
>  * dt-bindings: remove $ref from ohms value
> 
> V4 -> V5
>  * dt-bindings: include headers necessary
>  * dt-bindings: add IRQ_TYPE_EDGE_FALLING to interrupt flags
>  * dt-bindings: ohm -> ohms
>  * dt-bindings: spi0 -> spi
> 
> V5 -> V6
>  * fix warnings regarding overflows
> 
> V6 -> V7
>  * remove extra cache-line alignment
>  * adi,rsense-resistance-ohms -> shunt-resistor-micro-ohms
>  * dt-bindings: add product page links
> 
> V7 -> V8
>  * author using company email
>  * also check DAC code lower bound
>  * fix checkpath --strict complaints
>  * add comment regarding mutex lock usage
>  * propagate error when converting adc result to resistance
> 
> Cosmin Tanislav (3):
>   iio: add addac subdirectory
>   dt-bindings: iio: add AD74413R
>   iio: addac: add AD74413R driver
> 
>  .../bindings/iio/addac/adi,ad74413r.yaml      |  158 ++
>  MAINTAINERS                                   |    9 +
>  drivers/iio/Kconfig                           |    1 +
>  drivers/iio/Makefile                          |    1 +
>  drivers/iio/addac/Kconfig                     |   20 +
>  drivers/iio/addac/Makefile                    |    7 +
>  drivers/iio/addac/ad74413r.c                  | 1475 +++++++++++++++++
>  include/dt-bindings/iio/addac/adi,ad74413r.h  |   21 +
>  8 files changed, 1692 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml
>  create mode 100644 drivers/iio/addac/Kconfig
>  create mode 100644 drivers/iio/addac/Makefile
>  create mode 100644 drivers/iio/addac/ad74413r.c
>  create mode 100644 include/dt-bindings/iio/addac/adi,ad74413r.h
> 

Powered by blists - more mailing lists