linux-kernel - Re: [PATCH v3 net-next 0/5] prepare ocelot for external interface control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 4 Dec 2021 10:23:13 -0800
From:   Colin Foster <colin.foster@...advantage.com>
To:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Cc:     Vladimir Oltean <vladimir.oltean@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH v3 net-next 0/5] prepare ocelot for external interface
 control

On Sat, Dec 04, 2021 at 10:21:24AM -0800, Colin Foster wrote:
> This patch set is derived from an attempt to include external control
> for a VSC751[1234] chip via SPI. That patch set has grown large and is
> getting unwieldy for reviewers and the developers... me.
> 
> I'm breaking out the changes from that patch set. Some are trivial 
>   net: dsa: ocelot: remove unnecessary pci_bar variables
>   net: dsa: ocelot: felix: Remove requirement for PCS in felix devices
> 
> some are required for SPI
>   net: dsa: ocelot: felix: add interface for custom regmaps
> 
> and some are just to expose code to be shared
>   net: mscc: ocelot: split register definitions to a separate file
>   net: mscc: ocelot: expose ocelot wm functions
> 
> 
> The entirety of this patch set should have essentially no impact on the
> system performance.
> 
> v1 -> v2
>     * Removed the per-device-per-port quirks for Felix. Might be
>     completely unnecessary.
>     * Fixed the renaming issue for vec7514_regs. It includes the
>     Reported-by kernel test robot by way of git b4... If that isn't the
>     right thing to do in this instance, let me know :-)
> 
> v2 -> v3
>     * Fix an include. Thanks Jakub Kicinski!

Oops - I didn't use git b4 to pull in the reviewed by tags. Sending V4
with those changes and this fix. Apologies!

> 
> Colin Foster (5):
>   net: dsa: ocelot: remove unnecessary pci_bar variables
>   net: dsa: ocelot: felix: Remove requirement for PCS in felix devices
>   net: dsa: ocelot: felix: add interface for custom regmaps
>   net: mscc: ocelot: split register definitions to a separate file
>   net: mscc: ocelot: expose ocelot wm functions
> 
>  drivers/net/dsa/ocelot/felix.c             |   6 +-
>  drivers/net/dsa/ocelot/felix.h             |   4 +-
>  drivers/net/dsa/ocelot/felix_vsc9959.c     |  11 +-
>  drivers/net/dsa/ocelot/seville_vsc9953.c   |   1 +
>  drivers/net/ethernet/mscc/Makefile         |   3 +-
>  drivers/net/ethernet/mscc/ocelot_devlink.c |  31 ++
>  drivers/net/ethernet/mscc/ocelot_vsc7514.c | 548 +--------------------
>  drivers/net/ethernet/mscc/vsc7514_regs.c   | 523 ++++++++++++++++++++
>  include/soc/mscc/ocelot.h                  |   5 +
>  include/soc/mscc/vsc7514_regs.h            |  27 +
>  10 files changed, 610 insertions(+), 549 deletions(-)
>  create mode 100644 drivers/net/ethernet/mscc/vsc7514_regs.c
>  create mode 100644 include/soc/mscc/vsc7514_regs.h
> 
> -- 
> 2.25.1
>