linux-kernel - Re: [PATCH] x86/efi: select ARCH_USE_MEMREMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <120102a7-3c03-ce36-198c-f60f059a6cf9@amd.com>
Date:   Sun, 5 Dec 2021 09:15:15 -0600
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Ard Biesheuvel <ardb@...nel.org>, Arnd Bergmann <arnd@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        X86 ML <x86@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/efi: select ARCH_USE_MEMREMAP_PROT



On 12/4/21 11:55 AM, Ard Biesheuvel wrote:
> On Sat, 4 Dec 2021 at 18:42, Arnd Bergmann <arnd@...nel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> The patch to map the EFI memmap as encrypted introduces a
>> link failure in configurations without encryption support:
>>
>> x86_64-linux-ld: arch/x86/platform/efi/quirks.o: in function `efi_arch_mem_reserve':
>> quirks.c:(.init.text+0x127): undefined reference to `early_memremap_prot'
>>
>> Select the necessary symbol here as well to fix the build.
>>
>> Fixes: 8f1dd76c9b55 ("x86/sme: Explicitly map new EFI memmap table as encrypted")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Thanks for the report. I'll fold this fix into the original patch instead.

Thanks Arnd and Ard!

Tom

> 
>> ---
>>   arch/x86/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 05362527f6b5..93befe25d787 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -1934,6 +1934,7 @@ config EFI
>>          depends on ACPI
>>          select UCS2_STRING
>>          select EFI_RUNTIME_WRAPPERS
>> +       select ARCH_USE_MEMREMAP_PROT
>>          help
>>            This enables the kernel to use EFI runtime services that are
>>            available (such as the EFI variable services).
>> --
>> 2.29.2
>>