linux-kernel - Re: [PATCH v3 1/2] modpost: file2alias: make mdio alias configure match mdio uevent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YazhPOIIzpl43tzq@lunn.ch>
Date:   Sun, 5 Dec 2021 16:56:44 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     Yinbo Zhu <zhuyinbo@...ngson.cn>,
        Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH v3 1/2] modpost: file2alias: make mdio alias configure
 match mdio uevent

> The modalias string provided in the uevent sysfs file does not conform
> to the format used in PHY driver modules. One of the reasons is that
> udev loading of PHY driver modules has not been an expected use case.
> 
> This patch changes the MODALIAS entry for only PHY devices from:
> 	MODALIAS=of:Nethernet-phyT(null)
> to:
> 	MODALIAS=mdio:00000000001000100001010100010011

Hi Russell

You patch looks good for the straight forward cases.

What happens in the case of

        ethernet-phy@0 {
            compatible = "ethernet-phy-ieee802.3-c45";


Does this get appended to the end, or does it overwrite?

     Andrew