linux-kernel - Re: [PATCH 12/12] staging: r8188eu: hal_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9a77dba-45fe-3d0e-438b-acfa5bed693f@gmail.com>
Date:   Sun, 5 Dec 2021 19:09:59 +0100
From:   Michael Straube <straube.linux@...il.com>
To:     Pavel Skripkin <paskripkin@...il.com>, gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/12] staging: r8188eu: hal_data_sz is set but never used

Am 05.12.21 um 18:23 schrieb Pavel Skripkin:
> 
> and even why Haldata is void *, but not struct hal_data_8188e * :)
> 

I guess it's void because they use the same code for other chips.
And drivers for other chips perhaps use a different hal_data structure.

I'm working on embedding hal_data_8188e into the adapter structure
instead of using a pointer.

...still much work to do to get rid of the hal layer entirely. ;)

Regards,
Michael