linux-kernel - Re: [PATCH RFC V2 3/4] net: introduce media selection IF_PORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211206112955.285b26b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 6 Dec 2021 11:29:55 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Stefan Wahren <stefan.wahren@...e.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Michael Heimpold <michael.heimpold@...tech.com>,
        jimmy.shen@...texcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH RFC V2 3/4] net: introduce media selection
 IF_PORT_HOMEPLUG

On Sat,  4 Dec 2021 14:17:50 +0100 Stefan Wahren wrote:
> Introduce a new media selection dedicated for HomePlug powerline
> communication. This allows us to use the proper if_port setting in
> HomePlug drivers.
> 
> Suggested-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Stefan Wahren <stefan.wahren@...e.com>

I _think_ the IF_PORT API is an very ancient (Linux 2.2) way of
switching ports on early Ethernet cards. Isn't it? It predates
ethtool and all the modern interfaces. Quick grep seems to indicate
it's accessed only for old HW as well.

Do you have a use case for setting it?

> diff --git a/include/uapi/linux/netdevice.h b/include/uapi/linux/netdevice.h
> index f3770c5..0f1f536 100644
> --- a/include/uapi/linux/netdevice.h
> +++ b/include/uapi/linux/netdevice.h
> @@ -53,7 +53,8 @@ enum {
>          IF_PORT_AUI,
>          IF_PORT_100BASET,
>          IF_PORT_100BASETX,
> -        IF_PORT_100BASEFX
> +        IF_PORT_100BASEFX,
> +        IF_PORT_HOMEPLUG
>  };
>  
>  /* hardware address assignment types */