linux-kernel - Re: [PATCH] completion: introduce complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Dec 2021 15:17:23 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yajun Deng <yajun.deng@...ux.dev>, mingo@...hat.com,
        juri.lelli@...hat.com, vincent.guittot@...aro.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, bristot@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] completion: introduce complete_put() helper function

Hi Yajun,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on v5.16-rc4 next-20211203]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Yajun-Deng/completion-introduce-complete_put-helper-function/20211206-120632
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 8c92606ab81086db00cbb73347d124b4eb169b7e
config: hexagon-randconfig-r031-20211206 (https://download.01.org/0day-ci/archive/20211206/202112061502.0pJtOzSU-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f50be8eb0a12a61d23db6cda452c693001d76898)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/6d181628873250fd66a8f2da19182fec95973b6e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yajun-Deng/completion-introduce-complete_put-helper-function/20211206-120632
        git checkout 6d181628873250fd66a8f2da19182fec95973b6e
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash kernel/sched/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> kernel/sched/completion.c:41:6: warning: no previous prototype for function 'complete_put' [-Wmissing-prototypes]
   void complete_put(refcount_t *r, struct completion *x)
        ^
   kernel/sched/completion.c:41:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void complete_put(refcount_t *r, struct completion *x)
   ^
   static 
   1 warning generated.


vim +/complete_put +41 kernel/sched/completion.c

    40	
  > 41	void complete_put(refcount_t *r, struct completion *x)
    42	{
    43		if (refcount_dec_and_test(r))
    44			complete(x);
    45	}
    46	EXPORT_SYMBOL(complete_put);
    47	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org