linux-kernel - Re: [PATCH v4 3/3] phy: amlogic: meson8b-usb2: fix shared reset control use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCAtuo46FGFoa=pObfuvTq0u7PXJhUpfHd34CCis7T1HQQ@mail.gmail.com>
Date:   Mon, 6 Dec 2021 22:14:15 +0100
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Amjad Ouled-Ameur <aouledameur@...libre.com>
Cc:     khilman@...libre.com, p.zabel@...gutronix.de, balbi@...nel.org,
        jbrunet@...libre.com, linux-amlogic@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v4 3/3] phy: amlogic: meson8b-usb2: fix shared reset
 control use

On Sun, Dec 5, 2021 at 10:59 PM Amjad Ouled-Ameur
<aouledameur@...libre.com> wrote:
>
> Use reset_control_rearm() call if an error occurs in case
> phy_meson8b_usb2_power_on() fails after reset() has been called, or in
> case phy_meson8b_usb2_power_off() is called i.e the resource is no longer
> used and the reset line may be triggered again by other devices.
>
> reset_control_rearm() keeps use of triggered_count sane in the reset
> framework, use of reset_control_reset() on shared reset line should
> be balanced with reset_control_rearm().
>
> Signed-off-by: Amjad Ouled-Ameur <aouledameur@...libre.com>
> Reported-by: Jerome Brunet <jbrunet@...libre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>