linux-kernel - Re: [PATCH v6] ARM: dts: aspeed: Adding Facebook Bletchley BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ya5/v+VhOM9o9BtQ@heinlein>
Date:   Mon, 6 Dec 2021 15:25:19 -0600
From:   Patrick Williams <patrick@...cx.xyz>
To:     Howard Chiu <howard10703049@...il.com>
Cc:     arnd@...db.de, olof@...om.net, soc@...nel.org, robh+dt@...nel.org,
        joel@....id.au, andrew@...id.au,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-aspeed@...ts.ozlabs.org,
        Howard Chiu <howard.chiu@...ntatw.com>
Subject: Re: [PATCH v6] ARM: dts: aspeed: Adding Facebook Bletchley BMC

On Wed, Dec 01, 2021 at 11:37:38AM +0800, Howard Chiu wrote:
> Initial introduction of Facebook Bletchley equipped with
> Aspeed 2600 BMC SoC.
> 
> Signed-off-by: Howard Chiu <howard.chiu@...ntatw.com>
> 

...

> Change since v2:
> - Remove uart5 workaround
> - Remove gpio nodes of pca9552/pca9539
> - Modify gpio-line-name of led/power/presence pins with openbmc pattern

A number of the GPIOs do not have defined openbmc patterns for them yet.  The
names you have chosen are ok for now, but we will be changing them as we refine
development of this machine further.

> +		gpio-line-names =
> +		"SLED0_MS_DETECT1","SLED0_VBUS_BMC_EN","SLED0_INA230_ALERT","SLED0_P12V_STBY_ALERT",
> +		"SLED0_SSD_ALERT","SLED0_MS_DETECT0","SLED0_RST_CCG5","SLED0_FUSB302_INT",
> +		"SLED0_MD_STBY_RESET","SLED0_MD_IOEXP_EN_FAULT","SLED0_MD_DIR","SLED0_MD_DECAY",
> +		"SLED0_MD_MODE1","SLED0_MD_MODE2","SLED0_MD_MODE3","power-host0";

Such as these...

> -- 
> 2.25.1
> 

Otherwise,

Reviewed-by: Patrick Williams <patrick@...cx.xyz>

-- 
Patrick Williams

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)