linux-kernel - Re: [Linux-stm32] [PATCH] dmaengine: stm32-mdma: Remove redundant initialization of pointer hwdesc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Dec 2021 09:29:27 +0100
From:   Amelie DELAUNAY <amelie.delaunay@...s.st.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        Vinod Koul <vkoul@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        <dmaengine@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [Linux-stm32] [PATCH] dmaengine: stm32-mdma: Remove redundant
 initialization of pointer hwdesc

Hi,

On 12/4/21 3:00 PM, Colin Ian King wrote:
> The pointer hwdesc is being initialized with a value that is never
> read, it is being updated later in a for-loop. The assignment is
> redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Reviewed-by: Amelie Delaunay <amelie.delaunay@...s.st.com>

> ---
>   drivers/dma/stm32-mdma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c
> index d30a4a28d3bf..805a449ff301 100644
> --- a/drivers/dma/stm32-mdma.c
> +++ b/drivers/dma/stm32-mdma.c
> @@ -1279,7 +1279,7 @@ static size_t stm32_mdma_desc_residue(struct stm32_mdma_chan *chan,
>   				      u32 curr_hwdesc)
>   {
>   	struct stm32_mdma_device *dmadev = stm32_mdma_get_dev(chan);
> -	struct stm32_mdma_hwdesc *hwdesc = desc->node[0].hwdesc;
> +	struct stm32_mdma_hwdesc *hwdesc;
>   	u32 cbndtr, residue, modulo, burst_size;
>   	int i;
>   
>