linux-kernel - Re: [PATCH] media: venus: helpers: Fix memory leak in venus_helper_alloc_dpb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <163878415444.147210.13155524098900308326@Monstersaurus>
Date:   Mon, 06 Dec 2021 09:49:14 +0000
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     José Expósito <jose.exposito89@...il.com>,
        stanimir.varbanov@...aro.org, Ameer Hamza <amhamza.mgc@...il.com>
Cc:     agross@...nel.org, bjorn.andersson@...aro.org, mchehab@...nel.org,
        linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        José Expósito <jose.exposito89@...il.com>
Subject: Re: [PATCH] media: venus: helpers: Fix memory leak in venus_helper_alloc_dpb_bufs

Hi José

Quoting José Expósito (2021-12-05 19:04:15)
> Addresses-Coverity-ID: 1494120 ("Resource leaks")

This was also recently posted by Ameer in https://lore.kernel.org/all/20211204205504.6550-1-amhamza.mgc@gmail.com/

Regards
--
Kieran

> Signed-off-by: José Expósito <jose.exposito89@...il.com>
> ---
>  drivers/media/platform/qcom/venus/helpers.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
> index 84c3a511ec31..344a42853898 100644
> --- a/drivers/media/platform/qcom/venus/helpers.c
> +++ b/drivers/media/platform/qcom/venus/helpers.c
> @@ -197,6 +197,7 @@ int venus_helper_alloc_dpb_bufs(struct venus_inst *inst)
>  
>                 id = ida_alloc_min(&inst->dpb_ids, VB2_MAX_FRAME, GFP_KERNEL);
>                 if (id < 0) {
> +                       kfree(buf);
>                         ret = id;
>                         goto fail;
>                 }
> -- 
> 2.25.1
>