linux-kernel - Re: [PATCHv5 3/4] tracing: Add register read/write tracing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a97be342-21e3-54f1-ea36-db67747b7a70@quicinc.com>
Date:   Mon, 6 Dec 2021 16:22:11 +0530
From:   Sai Prakash Ranjan <quic_saipraka@...cinc.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Will Deacon <will@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Marc Zyngier <maz@...nel.org>,
        gregkh <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        <quic_psodagud@...cinc.com>,
        Prasad Sodagudi <psodagud@...eaurora.org>
Subject: Re: [PATCHv5 3/4] tracing: Add register read/write tracing support

On 12/6/2021 4:16 PM, Arnd Bergmann wrote:
> On Mon, Dec 6, 2021 at 11:11 AM Sai Prakash Ranjan
> <quic_saipraka@...cinc.com> wrote:
>> On 12/6/2021 2:29 PM, Arnd Bergmann wrote:
>>> On Mon, Dec 6, 2021 at 9:28 AM Sai Prakash Ranjan
>>>> +void log_read_mmio(u8 width, const volatile void __iomem *addr)
>>>> +{
>>>> +       trace_rwmmio_read(CALLER_ADDR0, CALLER_ADDR1, width, addr);
>>>> +}
>>> Here, it may be better to pass the caller address as an argument, I think
>>> CALLER_ADDR1 is not always reliable, though it's possible that it is
>>> in the configurations when this file gets enabled.
>>>
>>>
>> Do you mean that we use __builtin_return_address(0,1) directly here or
>> that I pass __func__ as the argument to log_read/write_mmio or is there
>> some other way to pass the caller address?
> I meant passing CALLER_ADDR0 from readl() down to
> log_read_mmio().
>
>         Arnd

Ah ok, will do that and remove CALLER_ADDR1.

Thanks,
Sai