linux-kernel - Re: [PATCH] dt-bindings: net: cdns,macb: Convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37b26b32-5828-df7f-3f73-6b9a4ef9d4e4@xilinx.com>
Date:   Mon, 6 Dec 2021 13:16:04 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Rob Herring <robh@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Stefano Stabellini <stefanos@...inx.com>
CC:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        netdev <netdev@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michal Simek <michal.simek@...inx.com>
Subject: Re: [PATCH] dt-bindings: net: cdns,macb: Convert to json-schema

Hi,

On 12/2/21 16:53, Rob Herring wrote:
> On Thu, Dec 2, 2021 at 4:10 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>>
>> Hi Rob,
>>
>> CC Michal
>>
>> On Thu, Dec 2, 2021 at 12:25 AM Rob Herring <robh@...nel.org> wrote:
>>> On Fri, Nov 26, 2021 at 12:57:00PM +0100, Geert Uytterhoeven wrote:
>>>> Convert the Cadence MACB/GEM Ethernet controller Device Tree binding
>>>> documentation to json-schema.
>>>>
>>>> Re-add "cdns,gem" (removed in commit a217d8711da5c87f ("dt-bindings:
>>>> Remove PicoXcell bindings")) as there are active users on non-PicoXcell
>>>> platforms.
>>>> Add missing "ether_clk" clock.
>>>> Add missing properties.
>>>>
>>>> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>>
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>>
>>>> +  '#stream-id-cells':
>>>> +    const: 1
>>>
>>> I can't figure out why you have this here. I'll drop it while applying.
>>
>> See arch/arm64/boot/dts/xilinx/zynqmp.dtsi and
>> drivers/iommu/arm/arm-smmu/arm-smmu.c.
>>
>> It wasn't clear to me if this is still needed, or legacy. Michal?
> 
> They should update to the iommu binding instead of the legacy smmu
> one. It's been around for years now.

At the beginning it was there for XEN usage which was using this legacy 
binding.
Stefano: Please confirm that it is not needed anymore that we can remove 
it for zynqmp and versal.

Thanks,
Michal