linux-kernel - Re: [PATCH] serial: 8250_pci: remove redundant assignment to tmp after the mask operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ya4UP5ceA8jINvVT@smile.fi.intel.com>
Date:   Mon, 6 Dec 2021 15:46:39 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-serial@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: 8250_pci: remove redundant assignment to tmp
 after the mask operation

On Sun, Dec 05, 2021 at 11:28:22PM +0000, Colin Ian King wrote:
> The variable tmp is being masked with a bitmask and the value is being
> written to port base + 0x3c.  However, the masked value is being written
> back to tmp and tmp is never used after this. The assignmentment is
> redundant, replace the &= operator with just &.

Make sense (maybe you can replace all those 0x00...BIT...00 by BIT()
and GENMASK() later on).

Reviewesd-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/tty/serial/8250/8250_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index 60f8fffdfd77..81aac3c25ead 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -1278,7 +1278,7 @@ static int pci_quatech_init(struct pci_dev *dev)
>  			outl(inl(base + 0x38) | 0x00002000, base + 0x38);
>  			tmp = inl(base + 0x3c);
>  			outl(tmp | 0x01000000, base + 0x3c);
> -			outl(tmp &= ~0x01000000, base + 0x3c);
> +			outl(tmp & ~0x01000000, base + 0x3c);
>  		}
>  	}
>  	return 0;
> -- 
> 2.33.1
> 

-- 
With Best Regards,
Andy Shevchenko