linux-kernel - Re: [PATCH 0/5] printk/console: Registration code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ya4WGZT0emR96h0B@alley>
Date:   Mon, 6 Dec 2021 14:54:33 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     John Ogness <john.ogness@...utronix.de>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] printk/console: Registration code cleanup - part 1

On Mon 2021-11-22 14:26:44, Petr Mladek wrote:
> The console registration code has several twists that are hard to follow.
> It is result of various features added over the last few decades.
> 
> I have already spent many days to understand all the effects and
> the desired behavior. I am always scared to touch the console registration
> code even after years working as printk maintainer.
> 
> There were several changes in the code that had to be reverted because
> they caused regression, for example:
> 
>    + commit dac8bbbae1d0ccba96402 ("Revert "printk: fix double printing
>      with earlycon")
> 
>    + commit c6c7d83b9c9e6a8b3e6d ("Revert "console: don't prefer first
>      registered if DT specifies stdout-path")
> 
> 
> This patchset removes the most tricky twists from my POV. I have worked
> on it when time permitted since January. I have spent most of the time
> writing the commit message, understanding, and explaining the effects.
> I am not sure if I succeeded but it is time to send this.
> 
> 
> Behavior change:
> 
> There is one behavior change caused by 4th patch. I consider it bug fix.
> It should be acceptable. See the commit message for more details.

I am afraid that the patchset is not easy to review. I decided to help
a bit and give it a spin in linux-next.

The patchset has been committed into printk/linux.git, branch
console-registration-cleanup. It should appear in linux-next
during the next respin.

I am going to take it back when anyone reports any problem that
can't be fixed easily.

Any feedback is still appreciated.

Best Regards,
Petr