linux-kernel - Re: [PATCH] staging: rtl8712: Fix alignment checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211206142231.GB1956@kadam>
Date:   Mon, 6 Dec 2021 17:22:31 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Ngo Tak Fong <simon.fodin@...il.com>
Cc:     Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Fix alignment checks

On Mon, Dec 06, 2021 at 08:19:49AM +0800, Ngo Tak Fong wrote:
> Fixed two CHECKs of Alignment should match open parenthesis.
> 
> Signed-off-by: Ngo Tak Fong <simon.fodin@...il.com>
> ---
>  drivers/staging/rtl8712/rtl8712_efuse.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
> index 4f3b54a7c3be..3555f612a066 100644
> --- a/drivers/staging/rtl8712/rtl8712_efuse.c
> +++ b/drivers/staging/rtl8712/rtl8712_efuse.c
> @@ -300,16 +300,15 @@ static u8 fix_header(struct _adapter *adapter, u8 header, u16 header_addr)
>  		for (i = 0; i < PGPKG_MAX_WORDS; i++) {
>  			if (BIT(i) & word_en) {

The real problem is this code is jammed up against the right hand side
of the screen.  Just flip this condition around and pull the code in
one tab.

			if (!(BIT(i) & word_en)
				continue;

>  				if (BIT(i) & pkt.word_en) {
> -					if (efuse_one_byte_read(
> -							adapter, addr,
> -							&value))
> +					if (efuse_one_byte_read(adapter,
> +								addr,
> +								&value))

reards,
dan carpenter