[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAL_JsqKzv4GLN8bmskKcA6HE+6nqDwOz=1oGW+z7r6joBFjKLA@mail.gmail.com>
Date: Tue, 7 Dec 2021 09:17:02 -0600
From: Rob Herring <robh+dt@...nel.org>
To: Rafał Miłecki <zajec5@...il.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
Rafał Miłecki <rafal@...ecki.pl>,
patches@...nsource.cirrus.com
Subject: Re: [PATCH REBASE] dt-bindings: pinctrl: use pinctrl.yaml
On Tue, Dec 7, 2021 at 2:47 AM Rafał Miłecki <zajec5@...il.com> wrote:
>
> On 06.12.2021 23:50, Rob Herring wrote:
> > On Thu, Dec 2, 2021 at 12:32 AM Rafał Miłecki <zajec5@...il.com> wrote:
> >>
> >> From: Rafał Miłecki <rafal@...ecki.pl>
> >>
> >> Also fix some examples to avoid warnings like:
> >> brcm,ns-pinmux.example.dt.yaml: pin-controller@...0c1c0: $nodename:0: 'pin-controller@...0c1c0' does not match '^pinctrl|pinmux@[0-9a-f]+$'
> >
> > I think you missed some. linux-next now has these warnings:
>
> Oops, sorry, I think I didn't test MFD bindings *after* modifying
> pinctrl bindings.
>
>
> > /builds/robherring/linux-dt/Documentation/devicetree/bindings/mfd/cirrus,madera.example.dt.yaml:
> > codec@1a: $nodename:0: 'codec@1a' does not match
> > '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
> > From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml
>
> I'm not sure how to deal with this one. If you take a look at
> cirrus,madera.yaml it seems to be some complex MFD that is a sound
> device with pin controller and regulator.
>
> I'm not sure: is using pinctrl@ node for that hardware is a correct
> choice?
No, I think you have to drop specifying the node name.
Rob
Powered by blists - more mailing lists