linux-kernel - Re: [PATCH v2 05/14] dt-bindings: gpio: Convert Broadcom STB GPIO to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df5cc6a5-7857-d86d-e739-9a592b3a5294@gmail.com>
Date:   Tue, 7 Dec 2021 09:52:45 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Rob Herring <robh@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     Marc Zyngier <maz@...nel.org>, Zhang Rui <rui.zhang@...el.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Doug Berger <opendmb@...il.com>, linux-usb@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-mmc@...r.kernel.org, Al Cooper <alcooperx@...il.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Amit Kucheria <amitk@...nel.org>, linux-pm@...r.kernel.org,
        linux-crypto@...r.kernel.org, Markus Mayer <mmayer@...adcom.com>,
        Ray Jui <rjui@...adcom.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Lee Jones <lee.jones@...aro.org>, linux-gpio@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>, linux-rtc@...r.kernel.org,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        devicetree@...r.kernel.org, Gregory Fong <gregory.0xf0@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Scott Branden <sbranden@...adcom.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Thierry Reding <thierry.reding@...il.com>,
        bcm-kernel-feedback-list@...adcom.com,
        "Rafael J. Wysocki" <rafael@...nel.org>, linux-ide@...r.kernel.org,
        linux-pwm@...r.kernel.org
Subject: Re: [PATCH v2 05/14] dt-bindings: gpio: Convert Broadcom STB GPIO to
 YAML

On 12/7/21 6:58 AM, Rob Herring wrote:
> On Mon, 06 Dec 2021 10:26:07 -0800, Florian Fainelli wrote:
>> Convert the Broadcom STB GPIO Device Tree binding to YAML to help with
>> validation.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>> ---
>>  .../bindings/gpio/brcm,brcmstb-gpio.txt       |  83 --------------
>>  .../bindings/gpio/brcm,brcmstb-gpio.yaml      | 105 ++++++++++++++++++
>>  MAINTAINERS                                   |   2 +-
>>  3 files changed, 106 insertions(+), 84 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt
>>  create mode 100644 Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml
>>
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/1564132
> 
> 
> gpio@...2c0: interrupts-extended: [[6, 6], [7, 5]] is too long
> 	arch/arm/boot/dts/bcm7445-bcm97445svmb.dt.yaml

The property is correct AFAICT, we have:

                        interrupts-extended = <&irq0_aon_intc 0x6>,
                                              <&aon_pm_l2_intc 0x5>;

with both interrupt controllers having #interrupt-cells = <1>. I tried
documenting the interrupts-extended for brcm,brcmstb-gpio.yaml to have
maxItems: 2 but that does not eliminate the warning. Do you have any
suggestions?
-- 
Florian