linux-kernel - Re: [PATCH v2 0/5] aio: fix use-after-free and missing wakeups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ya+xl9peAAMiMCqa@sol.localdomain>
Date:   Tue, 7 Dec 2021 11:10:15 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Benjamin LaHaise <bcrl@...ck.org>, linux-aio@...ck.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ramji Jiyani <ramjiyani@...gle.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Oleg Nesterov <oleg@...hat.com>, Jens Axboe <axboe@...nel.dk>,
        Martijn Coenen <maco@...roid.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2 0/5] aio: fix use-after-free and missing wakeups

On Tue, Dec 07, 2021 at 12:17:58PM +0100, Christoph Hellwig wrote:
> On Tue, Dec 07, 2021 at 01:57:21AM -0800, Eric Biggers wrote:
> > This series fixes two bugs in aio poll, and one issue with POLLFREE more
> > broadly.  This is intended to replace
> > "[PATCH v5] aio: Add support for the POLLFREE"
> > (https://lore.kernel.org/r/20211027011834.2497484-1-ramjiyani@google.com)
> > which has some bugs.
> > 
> > Careful review is appreciated; the aio poll code is very hard to work
> > with, and I don't know of an easy way to test it.  Suggestions of any
> > aio poll tests to run would be greatly appreciated.
> 
> libaio has a test for aio poll (test 22).

Great, it doesn't look very comprehensive but at least it is something.  I ran
the whole libaio test suite (including that test), and all the tests pass both
before and after this patch series.

- Eric