linux-kernel - Re: [PATCH v4] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6af56f1-7e6b-81ca-7bae-8f2a2dfaf0eb@gmail.com>
Date:   Tue, 7 Dec 2021 21:44:48 +0200
From:   Péter Ujfalusi <peter.ujfalusi@...il.com>
To:     Jayesh Choudhary <j-choudhary@...com>, robh+dt@...nel.org
Cc:     lgirdwood@...il.com, broonie@...nel.org,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] ASoC: dt-bindings: davinci-mcasp: convert McASP
 bindings to yaml schema

Hi,

On 12/7/21 07:03, Jayesh Choudhary wrote:
>>> +  tdm-slots:
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>> +    description: number of channels over one serializer
>>> +    maxItems: 1
>>
>> and it has to be between 2 and 32, ignored in DIT mode (384 slots)
>>
> 
> Will add minimum and maximum. Should this be added as a conditional
> property when op-mode is 0 (I2S mode) and mark it as required?

That would make it much nicer, yes, thank you!

>>> +  port:
>>> +    description: connection for when McASP is used via graph card
>>> +    type: object
>>
>> I understand that it can be present under the mcasp node as it is part
>> of the graph card binding (or a card binding using graph).
>> I mean if a new card binding comes around then we need to document it
>> here as well?
>>
> 
> Specific properties are not marked for the port. So it should not be an
> issue. Other alternative is to mark the additional properties as true
> but that is not preferred.

If the McASP is used with simple-sound-card (as it is the case most of
the time) then the port is not present under the node for this device as
the card is not using graph.
I consider the port (and the #sound-dai-cells if we are here) not part
of the McASP hardware description as they are part of the graph or
simple-card binding.

I'm fine if the port remains here

> Peter,
> Any other changes I should make?

Not much, this already looking good.
I would fix the dts files which generates warning/error with this yaml
as they are incorrect.

-- 
Péter