linux-kernel - Re: [PATCH] drm/bridge: sn65dsi86: defer if there is no dsi host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2606289.mvXUDI8C0e@jernej-laptop>
Date:   Tue, 07 Dec 2021 21:35:15 +0100
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     Rob Clark <robdclark@...il.com>,
        Doug Anderson <dianders@...omium.org>
Cc:     dri-devel@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org,
        Maxime Ripard <maxime@...no.tech>,
        Stephen Boyd <swboyd@...omium.org>,
        Rob Clark <robdclark@...omium.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Robert Foss <robert.foss@...aro.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Sam Ravnborg <sam@...nborg.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/bridge: sn65dsi86: defer if there is no dsi host

Dne torek, 07. december 2021 ob 21:26:50 CET je Doug Anderson napisal(a):
> Hi,
> 
> On Tue, Dec 7, 2021 at 12:03 PM Rob Clark <robdclark@...il.com> wrote:
> > From: Rob Clark <robdclark@...omium.org>
> > 
> > Otherwise we don't get another shot at it if the bridge probes before
> > the dsi host is registered.  It seems like this is what *most* (but not
> > all) of the other bridges do.
> > 
> > It looks like this was missed in the conversion to attach dsi host at
> > probe time.
> > 
> > Fixes: c3b75d4734cb ("drm/bridge: sn65dsi86: Register and attach our DSI
> > device at probe") Signed-off-by: Rob Clark <robdclark@...omium.org>
> > ---
> > 
> >  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 02b490671f8f..3684e12fbac3
> > 100644
> > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > @@ -716,7 +716,7 @@ static int ti_sn_attach_host(struct ti_sn65dsi86
> > *pdata)> 
> >         host = of_find_mipi_dsi_host_by_node(pdata->host_node);
> >         if (!host) {
> >         
> >                 DRM_ERROR("failed to find dsi host\n");
> > 
> > -               return -ENODEV;
> > +               return -EPROBE_DEFER;
> 
> Can you delete the DRM_ERROR line?

or use dev_err_probe()

Best regards,
Jernej