linux-kernel - Re: [PATCH v2] tests: remove unneeded conversion to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Dec 2021 08:20:37 +0800
From:   David Yang <davidcomponentone@...il.com>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     shuah@...nel.org, ptikhomirov@...tuozzo.com,
        christian.brauner@...ntu.com, yang.guang5@....com.cn,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH v2] tests: remove unneeded conversion to bool

Thank you for your advice.

On Mon, Dec 06, 2021 at 12:03:06PM -0700, Shuah Khan wrote:
> On 12/5/21 5:07 PM, davidcomponentone@...il.com wrote:
> > From: Yang Guang <yang.guang5@....com.cn>
> > 
> > The coccinelle report
> > ./tools/testing/selftests/move_mount_set_group/move_mount_set_group_test.c:225:18-23:
> > WARNING: conversion to bool not needed here
> > Relational and logical operators evaluate to bool,
> > explicit conversion is overly verbose and unneeded.
> > 
> > Reported-by: Zeal Robot <zealci@....com.cn>
> > Signed-off-by: Yang Guang <yang.guang5@....com.cn>
> > 
> > ---
> > 
> > Changes in v2:
> > - Change the return type to bool.
> > ---
> >   .../move_mount_set_group/move_mount_set_group_test.c   | 10 +++++-----
> >   1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/tools/testing/selftests/move_mount_set_group/move_mount_set_group_test.c b/tools/testing/selftests/move_mount_set_group/move_mount_set_group_test.c
> > index 860198f83a53..50ed5d475dd1 100644
> > --- a/tools/testing/selftests/move_mount_set_group/move_mount_set_group_test.c
> > +++ b/tools/testing/selftests/move_mount_set_group/move_mount_set_group_test.c
> > @@ -191,7 +191,7 @@ static bool is_shared_mount(const char *path)
> >   #define SET_GROUP_FROM	"/tmp/move_mount_set_group_supported_from"
> >   #define SET_GROUP_TO	"/tmp/move_mount_set_group_supported_to"
> > -static int move_mount_set_group_supported(void)
> > +static bool move_mount_set_group_supported(void)
> >   {
> >   	int ret;
> > @@ -222,7 +222,7 @@ static int move_mount_set_group_supported(void)
> >   		      AT_FDCWD, SET_GROUP_TO, MOVE_MOUNT_SET_GROUP);
> >   	umount2("/tmp", MNT_DETACH);
> > -	return ret < 0 ? false : true;
> > +	return ret >= 0;
> >   }
> >   FIXTURE(move_mount_set_group) {
> > @@ -232,7 +232,7 @@ FIXTURE(move_mount_set_group) {
> >   FIXTURE_SETUP(move_mount_set_group)
> >   {
> > -	int ret;
> > +	bool ret;
> >   	ASSERT_EQ(prepare_unpriv_mountns(), 0);
> > @@ -254,7 +254,7 @@ FIXTURE_SETUP(move_mount_set_group)
> >   FIXTURE_TEARDOWN(move_mount_set_group)
> >   {
> > -	int ret;
> > +	bool ret;
> >   	ret = move_mount_set_group_supported();
> >   	ASSERT_GE(ret, 0);
> > @@ -348,7 +348,7 @@ TEST_F(move_mount_set_group, complex_sharing_copying)
> >   		.shared = false,
> >   	};
> >   	pid_t pid;
> > -	int ret;
> > +	bool ret;
> >   	ret = move_mount_set_group_supported();
> >   	ASSERT_GE(ret, 0);
> > 
> 
> Applied. In the future use selftests/<test>: .... convention for
> patch summary. Review "git log <filename>" history for how to
> write summaries and change logs.
> 
> I fixed this one for now.
> 
> thanks,
> -- Shuah