linux-kernel - Re: [PATCH v2 1/2] dt-bindings: watchdog: Add Apple Watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd9a52eb-2aca-38a9-e183-2857960a4842@marcan.st>
Date:   Tue, 7 Dec 2021 13:35:43 +0900
From:   Hector Martin <marcan@...can.st>
To:     Guenter Roeck <linux@...ck-us.net>, Sven Peter <sven@...npeter.dev>
Cc:     Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, Janne Grunau <j@...nau.net>,
        Mark Kettenis <kettenis@...nbsd.org>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: watchdog: Add Apple Watchdog

On 02/12/2021 23.43, Guenter Roeck wrote:
> On Tue, Nov 30, 2021 at 05:18:08PM +0100, Sven Peter wrote:
>> Apple SoCs come with a simple embedded watchdog. This watchdog is also
>> required in order to reset the SoC.
>>
>> Reviewed-by: Mark Kettenis <kettenis@...nbsd.org>
>> Reviewed-by: Rob Herring <robh@...nel.org>
>> Signed-off-by: Sven Peter <sven@...npeter.dev>
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> 
>> ---
>> v1 --> v2:
>>    - add Mark's and Rob's r-b tags
>>
>>   .../bindings/watchdog/apple,wdt.yaml          | 52 +++++++++++++++++++
>>   MAINTAINERS                                   |  1 +
>>   2 files changed, 53 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
>> new file mode 100644
>> index 000000000000..e58c56a6fdf6
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
>> @@ -0,0 +1,52 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/watchdog/apple,wdt.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Apple SoC Watchdog
>> +
>> +allOf:
>> +  - $ref: "watchdog.yaml#"
>> +
>> +maintainers:
>> +  - Sven Peter <sven@...npeter.dev>
>> +
>> +properties:
>> +  compatible:
>> +    items:
>> +      - enum:
>> +          - apple,t8103-wdt
>> +          - apple,t6000-wdt
>> +      - const: apple,wdt
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - clocks
>> +  - interrupts
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/apple-aic.h>
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> +    wdt: watchdog@...00000 {
>> +        compatible = "apple,t8103-wdt", "apple,wdt";
>> +        reg = <0x50000000 0x4000>;
>> +        clocks = <&clk>;
>> +        interrupts = <AIC_IRQ 123 IRQ_TYPE_LEVEL_HIGH>;
>> +    };
>> +
>> +...
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 360e9aa0205d..859201bbd4e8 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1750,6 +1750,7 @@ F:	Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
>>   F:	Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml
>>   F:	Documentation/devicetree/bindings/pci/apple,pcie.yaml
>>   F:	Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml
>> +F:	Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
>>   F:	arch/arm64/boot/dts/apple/
>>   F:	drivers/i2c/busses/i2c-pasemi-core.c
>>   F:	drivers/i2c/busses/i2c-pasemi-platform.c
>> -- 
>> 2.25.1
>>
> 

I've gone ahead and applied this patch to the asahi-soc/dt tree, so we 
can build off of that to add the DT nodes.

Sven, can you spin a v3 with the MAINTAINERS split and just the driver 
itself, without this patch? I imagine Guenter will want to take the 
driver itself through the linux-watchdog tree.

-- 
Hector Martin (marcan@...can.st)
Public Key: https://mrcn.st/pub