linux-kernel - Re: [RFC PATCH 0/6] linkage: better symbol aliasing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211207052304.pb76ofjymf7o2yyb@treble>
Date:   Mon, 6 Dec 2021 21:23:04 -0800
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Mark Rutland <mark.rutland@....com>
Cc:     linux-kernel@...r.kernel.org, Borislav Petkov <bp@...en8.de>,
        Jiri Slaby <jslaby@...e.cz>,
        Peter Zijlstra <peterz@...radead.org>, ardb@...nel.org,
        broonie@...nel.org, catalin.marinas@....com,
        dave.hansen@...ux.intel.com, linux-arm-kernel@...ts.infradead.org,
        maz@...nel.org, mingo@...hat.com, tabba@...gle.com,
        tglx@...utronix.de, will@...nel.org
Subject: Re: [RFC PATCH 0/6] linkage: better symbol aliasing

On Mon, Dec 06, 2021 at 12:47:09PM +0000, Mark Rutland wrote:
> This avoids repetition and hopefully make it easier to ensure
> consistency (e.g. so each function has a single canonical name and
> associated metadata).
> 
> I'm sending this as an RFC since I want to check:
> 
> a) People are happy with the idea in principle.
> 
> b) People are happy with the implementation within <linux/linkage.h>.
> 
> ... and I haven't yet converted the headers under tools/, which is
> largely a copy+paste job.

Looks like a definite improvement to me.

The only suggestion I'd have would be to fix a minor naming
inconsistency: change "SYM_FUNC_LOCAL_ALIAS" to "SYM_FUNC_ALIAS_LOCAL"
to match the other "<noun>_<verb>" macros.

-- 
Josh