linux-kernel - Re: [PATCH v1] Bluetooth: hci_qca: Stop IBS timer during BT OFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c767becd1ded90dc0cf4b76f38d779b0@codeaurora.org>
Date:   Tue, 07 Dec 2021 11:09:35 +0530
From:   pharish@...eaurora.org
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>, mka@...omium.org,
        linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        hemantg@...eaurora.org, linux-arm-msm@...r.kernel.org,
        bgodavar@...eaurora.org, rjliao@...eaurora.org,
        hbandi@...eaurora.org, abhishekpandit@...omium.org,
        mcchou@...omium.org, saluvala@...eaurora.org
Subject: Re: [PATCH v1] Bluetooth: hci_qca: Stop IBS timer during BT OFF

On 2021-11-26 00:12, Marcel Holtmann wrote:
> Hi,
> 
>> This change stops IBS timers during BT OFF.
>> 
>> Signed-off-by: pharish <pharish@...eaurora.org>
> 
> clear name please.

[Harish]: will update

> 
>> ---
>> drivers/bluetooth/hci_qca.c | 3 +++
>> 1 file changed, 3 insertions(+)
>> 
>> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
>> index dd768a8..6f44b26 100644
>> --- a/drivers/bluetooth/hci_qca.c
>> +++ b/drivers/bluetooth/hci_qca.c
>> @@ -1928,6 +1928,9 @@ static int qca_power_off(struct hci_dev *hdev)
>> 	hu->hdev->hw_error = NULL;
>> 	hu->hdev->cmd_timeout = NULL;
>> 
>> +	mod_timer(&qca->tx_idle_timer, 0);
>> +	mod_timer(&qca->wake_retrans_timer, 0);
>> +
> 
> And I would really prefer if this gets changed to use a workqueue
> instead of a timer.

[Harish]: The full implementation of IBS is based on timers
to that reason I have switched to timers.

> 
> Regards
> 
> Marcel