linux-kernel - Re: [PATCH v3 1/4] Input: Add driver for Cypress Generation 5 touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ya8H3AHRqeJj7IUr@google.com>
Date:   Mon, 6 Dec 2021 23:06:04 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Alistair Francis <alistair23@...il.com>
Cc:     Andreas Kemnade <andreas@...nade.info>,
        Alistair Francis <alistair@...stair23.me>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-input <linux-input@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Henrik Rydberg <rydberg@...math.org>,
        Mylène Josserand 
        <mylene.josserand@...tlin.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>
Subject: Re: [PATCH v3 1/4] Input: Add driver for Cypress Generation 5
 touchscreen

On Mon, Dec 06, 2021 at 08:46:50PM +1000, Alistair Francis wrote:
> On Sun, Dec 5, 2021 at 8:32 AM Andreas Kemnade <andreas@...nade.info> wrote:
> >
> > Hi,
> >
> >
> > On Thu,  2 Dec 2021 22:20:18 +1000
> > Alistair Francis <alistair@...stair23.me> wrote:
> >
> > > From: Mylène Josserand <mylene.josserand@...tlin.com>
> > >
> > > This is the basic driver for the Cypress TrueTouch Gen5 touchscreen
> > > controllers. This driver supports only the I2C bus but it uses regmap
> > > so SPI support could be added later.
> > > The touchscreen can retrieve some defined zone that are handled as
> > > buttons (according to the hardware). That is why it handles
> > > button and multitouch events.
> > >
> > > Reviewed-by: Maxime Ripard <maxime.ripard@...tlin.com>
> > > Signed-off-by: Mylène Josserand <mylene.josserand@...tlin.com>
> > > Message-Id: <20180703094309.18514-2-mylene.josserand@...tlin.com>
> > > Signed-off-by: Alistair Francis <alistair@...stair23.me>
> >
> > I finally got it working. The order of initialisation is important.
> > Params are copied on input_mt_init_slots() from ABS_MT* to ABS_*, so you
> > have to set params first.
> >
> > Here is the patch i need on top of this one to make it actually work
> > with X (evdev and libinput is tested):
> >
> > diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
> > index b5d96eb71e46..3894ec85a732 100644
> > --- a/drivers/input/touchscreen/cyttsp5.c
> > +++ b/drivers/input/touchscreen/cyttsp5.c
> > @@ -415,19 +415,12 @@ static int cyttsp5_setup_input_device(struct device *dev)
> >         int max_x_tmp, max_y_tmp;
> >         int error;
> >
> > -       __set_bit(EV_REL, ts->input->evbit);
> 
> Does it work with this still included? I need this for my userspace program.

You need to fix your program, the kernel should not be declaring
capabilities that the device does not support.

Thanks.

-- 
Dmitry