linux-kernel - Re: [PATCH v19] tty: Fix the keyboard led light display problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ya8Lu1lo72w7JAud@google.com>
Date:   Mon, 6 Dec 2021 23:22:35 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     lianzhi chang <changlianzhi@...ontech.com>
Cc:     linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        jirislaby@...nel.org, andriy.shevchenko@...ux.intel.com,
        dan.carpenter@...cle.com, lkp@...el.com, 282827961@...com
Subject: Re: [PATCH v19] tty: Fix the keyboard led light display problem

On Wed, Dec 01, 2021 at 09:22:35AM +0800, lianzhi chang wrote:
> +	if (kb->kbdmode != VC_RAW &&
> +		 kb->kbdmode != VC_MEDIUMRAW &&
> +		 kb->kbdmode != VC_OFF) {
> +		vt_switch = true;
> +		set_leds();
> +	}

As I mentioned earlier, please do this unconditionally.

Thanks.

-- 
Dmitry