linux-kernel - Re: [PATCH 0/3] Fix Tegra194 HDA regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ya8Zk/9n7nAtjvSe@orome.fritz.box>
Date:   Tue, 7 Dec 2021 09:21:39 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Sameer Pujar <spujar@...dia.com>, tiwai@...e.com,
        broonie@...nel.org, lgirdwood@...il.com, robh+dt@...nel.org,
        perex@...ex.cz, jonathanh@...dia.com, digetx@...il.com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] Fix Tegra194 HDA regression

On Tue, Dec 07, 2021 at 09:04:54AM +0100, Takashi Iwai wrote:
> On Tue, 07 Dec 2021 07:32:47 +0100,
> Sameer Pujar wrote:
> > 
> > HDA probe failure is observed on Tegra194 based platforms and this
> > happens due to a reset failure. The series fixes this problem by
> > avoiding explicit resets on BPMP based devices.
> > 
> > Sameer Pujar (3):
> >   ALSA: hda/tegra: Skip reset on BPMP devices
> >   dt-bindings: sound: tegra: Update HDA resets
> >   arm64: tegra: Remove non existent Tegra194 reset
> 
> The change in HDA drier looks fine, and the question how to take those
> patches.  If other people can give acks, I can take those to sound.git
> tree destined for 5.16.
> 
> Or, if anyone else prefers taking those, feel free to do: for the
> first patch,
> 
> Reviewed-by: Takashi Iwai <tiwai@...e.de>

My understanding is that patches 1-2 are mostly independent of patch 3,
with the latter being mostly a complementary cleanup. Patch 1 will
effectively ignore the non-existent reset on Tegra194 anyway. Patch 1
(and potentially 2) could go into v5.16 to fix the regression via
sound.git, but the cleanup in patch 3 isn't time-critical, so I could
just queue that up for v5.17 via the Tegra tree.

Sameer, any objections to that? Did I miss anything?

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)