[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Ya8ayBtEq1UFbAEt@orome.fritz.box>
Date: Tue, 7 Dec 2021 09:26:48 +0100
From: Thierry Reding <thierry.reding@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Jose Abreu <joabreu@...opsys.com>, devicetree@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: net: snps,dwmac: Enable burst length
properties for more compatibles
On Mon, Dec 06, 2021 at 11:41:47AM -0600, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the properties
> 'snps,pbl', 'snps,txpbl', and 'snps,rxpbl' are not allowed in the
> examples for some of the DWMAC versions:
>
> Documentation/devicetree/bindings/net/intel,dwmac-plat.example.dt.yaml: ethernet@...00000: Unevaluated properties are not allowed ('snps,pbl', 'mdio0' were unexpected)
> Documentation/devicetree/bindings/net/stm32-dwmac.example.dt.yaml: ethernet@...0a000: Unevaluated properties are not allowed ('reg-names', 'snps,pbl' were unexpected)
> Documentation/devicetree/bindings/net/stm32-dwmac.example.dt.yaml: ethernet@...28000: Unevaluated properties are not allowed ('reg-names', 'snps,pbl' were unexpected)
> Documentation/devicetree/bindings/net/stm32-dwmac.example.dt.yaml: ethernet@...27000: Unevaluated properties are not allowed ('reg-names', 'snps,pbl' were unexpected)
> Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dt.yaml: ethernet@...00000: Unevaluated properties are not allowed ('snps,txpbl', 'snps,rxpbl', 'mdio0' were unexpected)
>
> This appears to be an oversight, so fix it by allowing the properties
> on the v3.50a, v4.10a, and v4.20a versions of the DWMAC.
>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>
> Cc: Jose Abreu <joabreu@...opsys.com>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Thierry Reding <treding@...dia.com>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists