linux-kernel - Re: [PATCH] dt-bindings: nvmem: Add missing 'reg' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bfd3425-77f6-e00b-e7f9-581917c6dc99@foss.st.com>
Date:   Tue, 7 Dec 2021 09:36:48 +0100
From:   Fabrice Gasnier <fabrice.gasnier@...s.st.com>
To:     Rob Herring <robh@...nel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Saenz Julienne <nsaenzjulienne@...e.de>
CC:     <devicetree@...r.kernel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Rafał Miłecki <rafal@...ecki.pl>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Patrick DELAUNAY-SCND-02 <patrick.delaunay@...s.st.com>
Subject: Re: [PATCH] dt-bindings: nvmem: Add missing 'reg' property

On 12/6/21 6:41 PM, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the following warnings
> are generated in the nvmem examples:
> 
> Documentation/devicetree/bindings/nvmem/st,stm32-romem.example.dt.yaml: efuse@...f7800: Unevaluated properties are not allowed ('reg' was unexpected)
> Documentation/devicetree/bindings/nvmem/rmem.example.dt.yaml: nvram@...00000: Unevaluated properties are not allowed ('reg' was unexpected)
> Documentation/devicetree/bindings/nvmem/brcm,nvram.example.dt.yaml: nvram@...f0000: Unevaluated properties are not allowed ('reg' was unexpected)
> 
> Add the missing 'reg' property definition.
> 
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>
> Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>
> Cc: Rafał Miłecki <rafal@...ecki.pl>
> Cc: Saenz Julienne <nsaenzjulienne@...e.de>
> Cc: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
> Cc: linux-stm32@...md-mailman.stormreply.com
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml     | 3 +++
>  Documentation/devicetree/bindings/nvmem/rmem.yaml           | 3 +++
>  Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml | 3 +++
>  3 files changed, 9 insertions(+)

Hi Rob,

For the stm32-romem, you can add my:

Reviewed-by: Fabrice Gasnier <fabrice.gasnier@...s.st.com>

Thanks,
Fabrice
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
> index 58ff6b0bdb1a..8c3f0cd22821 100644
> --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
> @@ -24,6 +24,9 @@ properties:
>    compatible:
>      const: brcm,nvram
>  
> +  reg:
> +    maxItems: 1
> +
>  unevaluatedProperties: false
>  
>  examples:
> diff --git a/Documentation/devicetree/bindings/nvmem/rmem.yaml b/Documentation/devicetree/bindings/nvmem/rmem.yaml
> index 1d85a0a30846..a4a755dcfc43 100644
> --- a/Documentation/devicetree/bindings/nvmem/rmem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/rmem.yaml
> @@ -19,6 +19,9 @@ properties:
>            - raspberrypi,bootloader-config
>        - const: nvmem-rmem
>  
> +  reg:
> +    maxItems: 1
> +
>    no-map:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description:
> diff --git a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
> index a48c8fa56bce..448a2678dc62 100644
> --- a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
> @@ -24,6 +24,9 @@ properties:
>        - st,stm32f4-otp
>        - st,stm32mp15-bsec
>  
> +  reg:
> +    maxItems: 1
> +
>  patternProperties:
>    "^.*@[0-9a-f]+$":
>      type: object
>