linux-kernel - Re: [PATCH 2/5] arm64: dts: HiSilicon: Add support for HiKey 970 PCIe controller hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61AF1F83.6010707@hisilicon.com>
Date:   Tue, 7 Dec 2021 16:46:59 +0800
From:   Wei Xu <xuwei5@...ilicon.com>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
CC:     Rob Herring <robh+dt@...nel.org>, <linuxarm@...wei.com>,
        <mauro.chehab@...wei.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/5] arm64: dts: HiSilicon: Add support for HiKey 970
 PCIe controller hardware

Hi Mauro,

On 2021/12/7 16:39, Mauro Carvalho Chehab wrote:
> Em Tue, 7 Dec 2021 16:09:16 +0800
> Wei Xu <xuwei5@...ilicon.com> escreveu:
> 
>> Hi Mauro,
>>
>> On 2021/11/16 19:59, Mauro Carvalho Chehab wrote:
>>> From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>>>
>>> Add DTS bindings for the HiKey 970 board's PCIe hardware.
>>>
>>> Co-developed-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
>>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
>>> ---
>>>
>>> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
>>> See [PATCH 0/5] at: https://lore.kernel.org/all/cover.1637063775.git.mchehab+huawei@kernel.org/
>>>
>>>  arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 107 ++++++++++++++++++++++
>>>  1 file changed, 107 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/hisilicon/hi3670.dtsi b/arch/arm64/boot/dts/hisilicon/hi3670.dtsi
>>> index 636c8817df7e..225dccbcb064 100644
>>> --- a/arch/arm64/boot/dts/hisilicon/hi3670.dtsi
>>> +++ b/arch/arm64/boot/dts/hisilicon/hi3670.dtsi
>>> @@ -176,6 +176,12 @@ sctrl: sctrl@...0a000 {
>>>  			#clock-cells = <1>;
>>>  		};
>>>  
>>> +		pmctrl: pmctrl@...31000 {
>>> +			compatible = "hisilicon,hi3670-pmctrl", "syscon";  
>>
>> The "hi3670-pmctrl" is not documented in the devicetree binding documents yet.
>> Could we remove this part this time?
> 
> Without that, the PCI PHY won't work.
> 
> IMO, the best would be to just add this compatible to hi3670-clock,
> where it belongs.
> 
> Just sent a patch.

Got it.
Thanks!

Best Regards,
Wei

> 
> Regards,
> Mauro
> 
> .
>