linux-kernel - Re: [PATCH] ASoC: soc-core: add the driver component name to the component struc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211207094732.3be5befb@kmaincent-XPS-13-7390>
Date:   Tue, 7 Dec 2021 09:47:32 +0100
From:   Köry Maincent <kory.maincent@...tlin.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        alexandre.belloni@...tlin.com, thomas.petazzoni@...tlin.com,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH] ASoC: soc-core: add the driver component name to the
 component struc

Hello Mark,

On Mon, 6 Dec 2021 19:33:58 +0000
Mark Brown <broonie@...nel.org> wrote:

> On Mon, Dec 06, 2021 at 10:59:20AM +0100, Kory Maincent wrote:
> 
> > If a non i2c driver register two components the function will return the
> > same "device_name" for both components. This could cause unexpected issue,
> > in my case it is a debugfs error which tries to create two directory with
> > the same component name.  
> 
> Why is one device registering multiple components in the first place?

Because the sound components are more and more complex. Why they shouldn't?

It seems to be already the case:
sound/soc/codecs/cros_ec_codec.c
sound/soc/fsl/fsl_easrc.c
sound/soc/mediatek/mt*/mt*-afe-pcm.c
sound/soc/sunxi/sun4i-codec.c
sound/soc/soc-utils.c

Regards,

Köry