linux-kernel - Re: [PATCH] dt-bindings: i2c: aspeed: Drop stray '#interrupt-cells'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ya8gB4mu3yFYCbhp@orome.fritz.box>
Date:   Tue, 7 Dec 2021 09:49:11 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Brendan Higgins <brendanhiggins@...gle.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Rayn Chen <rayn_chen@...eedtech.com>,
        devicetree@...r.kernel.org, linux-i2c@...r.kernel.org,
        openbmc@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: aspeed: Drop stray '#interrupt-cells'

On Mon, Dec 06, 2021 at 11:42:37AM -0600, Rob Herring wrote:
> '#interrupt-cells' is not documented which causes a warning when
> 'unevaluatedProperties' is implemented. Unless the I2C controller is
> also an interrupt controller, '#interrupt-cells' is not valid. This
> doesn't appear to be the case from the driver, so just remove it from
> the example.
> 
> Cc: Brendan Higgins <brendanhiggins@...gle.com>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Joel Stanley <joel@....id.au>
> Cc: Andrew Jeffery <andrew@...id.au>
> Cc: Rayn Chen <rayn_chen@...eedtech.com>
> Cc: linux-i2c@...r.kernel.org
> Cc: openbmc@...ts.ozlabs.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-aspeed@...ts.ozlabs.org
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 1 -
>  1 file changed, 1 deletion(-)

Interestingly I have a patch for this as well but it does the opposite
and adds interrupt-controller and #interrupt-cells. Upon closer
inspection I was tricked into this because the i2c-aspeed driver
includes linux/irqchip/chained_irq.h and linux/irqdomain.h and therefore
I assumed that it was indeed implementing an interrupt controller. But
none of the symbols in those files are ever used, so your version seems
to be correct.

Reviewed-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)