linux-kernel - Re: Building perf with BUILD_BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80DE21EF-C2F8-4F20-9748-5C6E2BF1472C@fb.com>
Date:   Tue, 7 Dec 2021 01:07:32 +0000
From:   Song Liu <songliubraving@...com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>
Subject: Re: Building perf with BUILD_BPF_SKEL=1 by default



> On Dec 6, 2021, at 4:49 PM, Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> 
> Em Mon, Dec 06, 2021 at 10:34:31PM +0000, Song Liu escreveu:
>>> From e033fd36657288ece383ba528aaff7b56eebfee2 Mon Sep 17 00:00:00 2001
>> From: Song Liu <songliubraving@...com>
>> Date: Fri, 3 Dec 2021 15:14:41 -0800
>> Subject: [PATCH] perf/bpf_skel: do not use typedef to avoid error on old clang
>> 
>> When building bpf_skel with clang-10, typedef causes confusions like:
>> 
>>  libbpf: map 'prev_readings': unexpected def kind var.
>> 
>> Fix this by removing the typedef.
>> 
>> Fixes: 7fac83aaf2ee ("perf stat: Introduce 'bperf' to share hardware PMCs with BPF")
> 
> Please get a larger sha abbrev:
> 
> ⬢[acme@...lbox perf]$ grep core -A1 ~/.gitconfig
> [core]
> 	abbrev = 16
> ⬢[acme@...lbox perf]$

Hmm.. I think the rule is to have 12 letters sha in the Fixes tag. Did we
change something recently?

Thanks,
Song