linux-kernel - Re: [PATCH] dt-bindings: watchdog: atmel: Add missing 'interrupts' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6944a02-ba13-2a0d-6ed4-7b1330348d68@microchip.com>
Date:   Tue, 7 Dec 2021 11:14:51 +0100
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Rob Herring <robh@...nel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Eugen Hristev <eugen.hristev@...rochip.com>
CC:     <devicetree@...r.kernel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        <linux-watchdog@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: watchdog: atmel: Add missing 'interrupts'
 property

On 06/12/2021 at 18:40, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the atmel,sama5d4-wdt
> example has the following warning:
> 
> /home/rob/proj/git/linux-dt/.build-arm64/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.example.dt.yaml: watchdog@...68640: Unevaluated properties are not allowed ('interrupts' was unexpected)
> 
> Document the missing 'interrupts' property.
> 
> Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Thanks for the fix Rob!
Best regards,
   Nicolas

> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@...rochip.com>
> Cc: Eugen Hristev <eugen.hristev@...rochip.com>
> Cc: linux-watchdog@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>   .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml        | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> index 9856cd76c28d..a9635c03761c 100644
> --- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> @@ -22,6 +22,9 @@ properties:
>     reg:
>       maxItems: 1
> 
> +  interrupts:
> +    maxItems: 1
> +
>     atmel,watchdog-type:
>       $ref: /schemas/types.yaml#/definitions/string
>       description: should be hardware or software.
> --
> 2.32.0
> 


-- 
Nicolas Ferre